Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme docs fix #5944

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Theme docs fix #5944

merged 1 commit into from
Mar 7, 2019

Conversation

PascalPixel
Copy link
Contributor

The doc says export default create({... for the theme, which gives an error when you do import { ... } from ...

The doc says `export default create({...` for the theme
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Superpencil 🚀

@shilman shilman merged commit cbfe932 into storybookjs:master Mar 7, 2019
@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 7, 2019
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #5944 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5944   +/-   ##
=======================================
  Coverage   34.38%   34.38%           
=======================================
  Files         636      636           
  Lines        9374     9374           
  Branches     1323     1323           
=======================================
  Hits         3223     3223           
  Misses       5508     5508           
  Partials      643      643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19ae6b...e122891. Read the comment docs.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 7, 2019
shilman added a commit that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants