updated docs to reflect proper params passed to webpack.config.js #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated docs to reflect proper params passed to webpack.config.js
Codecov Report
@@ Coverage Diff @@
## master #5929 +/- ##
=======================================
Coverage 34.38% 34.38%
=======================================
Files 636 636
Lines 9374 9374
Branches 1348 1348
=======================================
Hits 3223 3223
Misses 5508 5508
Partials 643 643Continue to review full report at Codecov.
|
|
@shilman @ndelangen @Hypnosphi i don't know how this passed previously (the block syntax wasn't modified). I'll leave it as a chore for you guys to either accept the patch as is, or remove the block syntax. |
shilman
approved these changes
Mar 6, 2019
shilman
added
configuration babel / webpack
documentation
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 7, 2019
updated docs to reflect proper params passed to webpack.config.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
updated docs to reflect proper params passed to webpack.config.js
How to test
no [review changes]
no
that's what this is.
If your answer is yes to any of these, please make sure to include it in your PR.