Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updated to reference jsDelivr for the badge #5905

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Readme updated to reference jsDelivr for the badge #5905

merged 1 commit into from
Mar 6, 2019

Conversation

maraisr
Copy link
Contributor

@maraisr maraisr commented Mar 6, 2019

Could we prompt people to use jsDelivr or alike? The github.com ones don't work outside of GitHub.

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 6, 2019
@shilman shilman added this to the 5.0.x milestone Mar 6, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 2680c4e into storybookjs:next Mar 6, 2019
@maraisr maraisr deleted the feature/readme-badge-does-no-work branch March 6, 2019 06:26
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 7, 2019
shilman added a commit that referenced this pull request Mar 7, 2019
Readme updated to reference jsDelivr for the badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants