Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the theme is insta-loaded from local storage #5856

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 5, 2019

Issue: Theme was not loading from local storage, leading to a FOUC

What I did

Read the correct key off local storage and preference persisted options to the defauls

How to test

Set theme: themes.dark and reload the SB

@vercel
Copy link

vercel bot commented Mar 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@tmeasday tmeasday added this to the v5.0.0 milestone Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #5856 into tech/improve-theme-creating will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           tech/improve-theme-creating    #5856   +/-   ##
============================================================
  Coverage                        34.99%   34.99%           
============================================================
  Files                              648      648           
  Lines                             9478     9478           
  Branches                          1332     1332           
============================================================
  Hits                              3317     3317           
  Misses                            5533     5533           
  Partials                           628      628
Impacted Files Coverage Δ
lib/ui/src/core/layout.js 13.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddead74...e5696dc. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit be7646e into tech/improve-theme-creating Mar 5, 2019
@shilman shilman deleted the tech/load-initial-theme branch March 5, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants