-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore viewport behaviour #5829
Conversation
Also restore using the `viewport` key, and enforce the viewport parameter to be a object.
Not sure why you'd want this, but it makes sense to support it.
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## next #5829 +/- ##
==========================================
- Coverage 34.28% 34.24% -0.05%
==========================================
Files 651 651
Lines 9473 9482 +9
Branches 1344 1374 +30
==========================================
- Hits 3248 3247 -1
- Misses 5611 5617 +6
- Partials 614 618 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tmeasday, this is awesome!
Issue: #5757 and #5818
A few things were going on here:
defaultViewport
any moreWhat I did
(Partially) restored the old API (still via the parameter API), added warnings for no-longer supported stuff, and documented it.
NOTE: we lost the
onViewportChange
option. I'm not sure that was very widely used? Maybe we'll hear about it if so 🤷♂️