-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX build-storybook with simplebar esm files #5816
Conversation
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## next #5816 +/- ##
====================================
Coverage 34% 34%
====================================
Files 651 651
Lines 9473 9473
Branches 1345 1371 +26
====================================
Hits 3221 3221
Misses 5637 5637
Partials 615 615
Continue to review full report at Codecov.
|
@ndelangen Thanks for figuring this out. You're a wizard 🧙♂️ |
Hmm.. this seems like a pretty big change no? Could users be relying on us resolving those those fields from |
@tmeasday I don't know why it was added, but it was 'recent'. I added it here: But no longer know why.. |
All good then 😆 |
FIX build-storybook with simplebar esm files
Issue: #5788
What I did
I changed a config for webpack for preview
Why
So after a bunch of experimentation and debugging, I found that
simplebar
&simplebar-react
expose.esm.js
AND.js
AND.min.js
files. For the preview configured it so it would load the.js
file. Turns out that files doesn't work well within a webpack bundle.Probably due to multiple polyfills.
I don't really have an explanation for why it worked in dev-mode.