Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knob changed debounce performance fix #5810

Closed
wants to merge 2 commits into from
Closed

Knob changed debounce performance fix #5810

wants to merge 2 commits into from

Conversation

CodeByAlex
Copy link
Member

@CodeByAlex CodeByAlex commented Mar 1, 2019

Issue: #5376

What I did

I added debouncing within the knob changed function to reduce the number of times that a component is rendered when the user is typing. The knob changed functionality will only be called if there is a delay of 155ms during user typing. The previous version re-rendered the component upon each keypress. This will help increase performance and is seen mostly when running large components within storybook.

For more information about this PR, please refer to #5376

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@vercel
Copy link

vercel bot commented Mar 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot requested a deployment to staging March 1, 2019 15:25 Abandoned
@vercel
Copy link

vercel bot commented Mar 1, 2019

You are pushing commits at a very fast pace (accross the whole organization).
Due to that, we cannot deploy the commit 7092be3.

You can try again later or upgrade your plan.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2019

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 7092be3

@CodeByAlex CodeByAlex closed this Mar 1, 2019
@CodeByAlex CodeByAlex deleted the knob-changed-debounce-performance-fix branch March 1, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant