Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate addon a11y to TS #5738

Merged
merged 7 commits into from
Mar 7, 2019
Merged

Migrate addon a11y to TS #5738

merged 7 commits into from
Mar 7, 2019

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Feb 24, 2019 •
edited by shilman
Loading

Issue: #5030

What I did

  • Migrate @storybook/addon-a11y to TypeScript
  • Refactor some imports/exports
  • Add some types and interfaces and use them to type codebase

@gaetanmaisse gaetanmaisse changed the title Ts migration/addon a11y Migrate addon a11y to TS Feb 24, 2019
@gaetanmaisse gaetanmaisse marked this pull request as ready for review February 24, 2019 18:25
@codecov
Copy link

codecov bot commented Feb 24, 2019 •
edited
Loading

Codecov Report

Merging #5738 into next will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5738      +/-   ##
==========================================
- Coverage   34.97%   34.91%   -0.06%     
==========================================
  Files         648      648              
  Lines        9480     9496      +16     
  Branches     1360     1345      -15     
==========================================
  Hits         3316     3316              
- Misses       5534     5563      +29     
+ Partials      630      617      -13
Impacted Files Coverage Δ
addons/a11y/src/components/Report/Info.tsx 0% <0%> (ø)
addons/a11y/src/components/Report/Tags.tsx 0% <0%> (ø)
addons/a11y/src/components/Report/index.tsx 0% <0%> (ø)
addons/a11y/src/components/Report/Rules.tsx 0% <0%> (ø)
addons/a11y/src/components/ColorBlindness.tsx 0% <0%> (ø)
addons/a11y/src/register.tsx 0% <0%> (ø)
addons/a11y/src/components/Report/Elements.tsx 0% <0%> (ø)
addons/a11y/src/components/Tabs.tsx 0% <0%> (ø)
addons/a11y/src/components/Report/Item.tsx 0% <0%> (ø)
addons/a11y/src/index.ts 0% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cb244...1c013a3. Read the comment docs.

Keraito
Keraito approved these changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@Keraito Keraito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small comments so please look into those! 😊

addons/a11y/src/components/A11YPanel.tsx Show resolved Hide resolved
addons/a11y/src/components/A11YPanel.tsx Show resolved Hide resolved
addons/a11y/src/components/ColorBlindness.tsx Outdated Show resolved Hide resolved
addons/a11y/src/components/Tabs.tsx Show resolved Hide resolved
@kroeder kroeder mentioned this pull request Feb 26, 2019
Closed
@shilman shilman added this to the v5.1.0 milestone Mar 2, 2019
@vercel vercel bot requested a deployment to staging March 2, 2019 18:26 Abandoned
@vercel
Copy link

vercel bot commented Mar 2, 2019

Deployment failed with the following error:

Builds rate limit exceeded (0 of 32 remaining). Try again in 25m

@vercel vercel bot requested a deployment to staging March 2, 2019 20:32 Abandoned
@gaetanmaisse gaetanmaisse mentioned this pull request Mar 5, 2019
Closed
@gaetanmaisse gaetanmaisse merged commit 77ad48e into storybookjs:next Mar 7, 2019
@gaetanmaisse gaetanmaisse deleted the ts-migration/addon-a11y branch March 7, 2019 19:23
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 17, 2019
@shilman
Copy link
Member

shilman commented Mar 17, 2019

FYI I'm patching this back into 5.0.x because the a11y bugfixes depend on this

@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 17, 2019
@shilman
Copy link
Member

shilman commented Mar 17, 2019

I take it back. a11y bugfixes will be available in 5.1 only

@gaetanmaisse gaetanmaisse mentioned this pull request Jun 24, 2019
Closed
7 tasks
@gaetanmaisse gaetanmaisse mentioned this pull request Aug 4, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keraito Keraito Keraito approved these changes

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

@danielduan danielduan Awaiting requested review from danielduan

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

@gaetanmaisse gaetanmaisse

Labels
addon: a11y maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gaetanmaisse @shilman @Keraito @ndelangen