Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech/api package #5402
Tech/api package #5402
Changes from 2 commits
accb7ff
5380276
c60b06d
0c3791d
b1c791d
0a0e4f2
1b716bb
ed44fd0
4fb6264
f893431
7a1fdc7
710025d
61f25fd
f230c41
d287d1f
c924ae0
5e24692
f20eecf
7412d7b
2b2e794
3f6d16d
d22ac67
fd96884
36e4cfa
6d2a260
2a3d7b0
b4c2fbc
8eec272
9c9dffe
de5e55a
b63280d
bbb56b2
ed60fbe
ab2b73f
781bd3f
4b194b1
39c4b0f
efddb56
cc668e5
0216f71
c04fbe5
9a1c01a
80c0842
eac8313
f0383ce
c84b49e
3a92016
5690954
7928db0
415663e
3a0ae06
a6c11a9
930e9e2
0994524
cb73f0f
51a9108
d19c4c7
39b93fa
a7cd8c3
28ae982
7fb28ec
7e12272
61c89d6
9f1ae25
dba15dc
843ee3c
223ea4d
1a3607c
3bdaa9e
2c5bf08
d689cdc
11e8a43
5592373
0b6528b
b3e111b
d0281d0
bf252cc
9b6905c
9744edb
1a7841e
77cfc5b
7c56ae7
b18b2c8
be2387f
b7bc65c
880723a
817c8a1
29a603a
9510552
62299a6
e73ffa8
accf970
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the modules should remain in
lib/ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the modules that are directly relevant to the UI, such as the layout state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly, do you have a suggestion on how to hook that up?
I feel like there a pros and cons to both approaches. Having the global state in 1 location is not a bad thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it depends what you mean. I would expect the state to all be stored in the one "store" but the code for setting/changing the UI's state would live in
lib/ui
. Similarly, addons set their own state in the same store but their store setting state lives in their codebase.I guess the question is how to make the APIs that the UI creates available to the addons in a principled/typed way. Would it make sense that if an addon wants to alter the UI's state (e.g. set fullscreen) that it should import something from
@storybook/ui
? I feel like that would be sensible.