Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate addon google analytics to TS #5307

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Migrate addon google analytics to TS #5307

merged 2 commits into from
Jan 21, 2019

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Jan 20, 2019

Issue:

#5030

(@kroeder I have preferred to start with a super simple addon)

What I did

Migrated @storybook/addon-google-analytics to TypeScript.

@@ -15,7 +15,6 @@
"url": "https://github.com/storybooks/storybook.git"
},
"license": "MIT",
"jsnext:main": "src/index.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because there was no src/index.js file.
Also I did not add main and type attributes as there is nothing to "export".

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against c71c901

@ndelangen ndelangen added maintenance User-facing maintenance tasks addon: analytics labels Jan 21, 2019
@ndelangen ndelangen added this to the v5.0.0 milestone Jan 21, 2019
@ndelangen
Copy link
Member

Awesome @gaetanmaisse, LGTM!

@ndelangen ndelangen merged commit 88edb65 into storybookjs:next Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: analytics maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants