Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript migration: @storybook/channel-websocket #5046

Merged
merged 3 commits into from
Dec 27, 2018

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Dec 19, 2018

Issue: #5030

What I did

Migrated @storybook/channel-websocket to TypeScript

@kroeder kroeder self-assigned this Dec 19, 2018
@kroeder kroeder added maintenance User-facing maintenance tasks typescript labels Dec 19, 2018
@kroeder kroeder requested a review from Hypnosphi as a code owner December 27, 2018 12:31
@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #5046 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5046      +/-   ##
==========================================
- Coverage   35.09%   35.07%   -0.02%     
==========================================
  Files         594      594              
  Lines        7358     7362       +4     
  Branches     1002     1007       +5     
==========================================
  Hits         2582     2582              
- Misses       4265     4271       +6     
+ Partials      511      509       -2
Impacted Files Coverage Δ
lib/channel-websocket/src/index.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c6d93...3af7223. Read the comment docs.

@ndelangen ndelangen merged commit be73549 into next Dec 27, 2018
@ndelangen ndelangen deleted the ts-migration/channel-websocket branch December 27, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants