Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include macro instructions for Storyshots docs #5015

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

kylemh
Copy link
Member

@kylemh kylemh commented Dec 17, 2018

Issue:

Background

Setting up Storybook in CRA2 with Storyshots is currently impossible without ejecting and using a plugin, or inlining a function which could be made into a library.

#4479 seems to cover the pain well.

I've published a macro for CRA2 users to easily mock/polyfill require.context in a test environment, and updated the documentation for Storyshots pointing out how to do so.

How to test

  • npx create-react-app test
  • Setup Storybook in test
  • Integrate Storyshots addon
  • Follow my instructions (in this PR)

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #5015 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5015   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files         579      579           
  Lines        7037     7037           
  Branches      943      943           
=======================================
  Hits         2453     2453           
  Misses       4081     4081           
  Partials      503      503

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e272e...59415fb. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmeasday tmeasday merged commit 2e7fe70 into next Dec 17, 2018
@tmeasday tmeasday deleted the update-storyshots-docs branch December 17, 2018 05:47
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Dec 18, 2018
shilman pushed a commit that referenced this pull request Dec 20, 2018
Include macro instructions for Storyshots docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants