Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE back to use html-webpack-plugin to keep compatibility with plugins that depend on it #4375

Merged
merged 6 commits into from
Oct 12, 2018

Conversation

ndelangen
Copy link
Member

should
fix: #4066
fix: #4234
fix: #3399

related:
#1775

reverts:
#3919

This uses the 4.0.0-alpha version of html-webpack-plugin

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@fb774e0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4375   +/-   ##
=========================================
  Coverage          ?   39.65%           
=========================================
  Files             ?      519           
  Lines             ?     5962           
  Branches          ?      800           
=========================================
  Hits              ?     2364           
  Misses            ?     3210           
  Partials          ?      388
Impacted Files Coverage Δ
...ct-native/src/server/config/webpack.config.prod.js 0% <0%> (ø)
...p/react-native/src/server/config/webpack.config.js 0% <0%> (ø)
lib/core/src/server/config/webpack.config.dev.js 0% <0%> (ø)
lib/core/src/server/config/webpack.config.prod.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb774e0...d379a8d. Read the comment docs.

@ndelangen ndelangen force-pushed the tech/reapply-html-plugin branch from ae35ec6 to b15048a Compare October 12, 2018 01:21
@ndelangen ndelangen force-pushed the tech/reapply-html-plugin branch from ca6f6b4 to 9f180d4 Compare October 12, 2018 06:21
@ndelangen ndelangen merged commit f29b163 into master Oct 12, 2018
@ndelangen ndelangen deleted the tech/reapply-html-plugin branch October 12, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant