-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to pass more webpack.config options #43
Conversation
} | ||
|
||
config = { ...config, customConfig }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is not what we should do. It's not possible to extend like this since it'll replace our configurations. But I mention is we can import his main webpack config into the webpack config in .storybook
directory and get any modules he use.
Currently we only support loaders and plugins. But, if we need something else we can specifically look at it. BTW: Thanks a lot for the PR. |
I removed the |
Could you show me the sample webpack config for |
Sure :) taken from the examples:
|
Thanks. We can discuss there. |
fix(ui/components/left_panel): use links for accessibility
Add a loading icon for loading comments for the first time.
* implement multiple docs navigation * change docs data strutcure * styling * fix routings when responsive view * Add some real docs. * Add all basics docs. * Add management features section. * Change style. * Change the header to add Storybook Hub. * Chaneg nav styles a bit. * fix some minor issues * fix storybook failing * change docs page title according to the categoryh * Add the comment screenshot.
Fix full page refresh problem
Improve confetti colors and shapes
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 06f6d68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
To support loader configurations (mentioned in #40), I made adjustments to support additional configuration properties.