Update addon-jest to new propType
#4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
Thanks @wuweiweiwu, I'll leave it to you to merge when you're ready - or let me know if I can do anything else. |
|
@mrmckeb usually we have at least 2 approving to merge. The Tc build failures seems unrelated |
|
is this going to get merged? Having the same issue ... |
danielduan
approved these changes
Oct 5, 2018
|
Guys, this merge broke the linter. Does anybody want to fix it? |
|
This merge now broke 5 tests. |
|
I think they all are related to the linter. Anyway, I prefer to revert this rather than diving into the real solution. Otherwise, somebody wants to fix it |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4251.
What I did
Changed title from React element to function returning React element, as per propType requirements.
How to test
Run this add-on as described in issue #4251. I've tested this locally and it works as expected.