Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add missing @babel/core dependency #4117

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

Issue: #4071 (comment)

@babel/core is now a peer dependency of @babel/register: babel/babel#6655

@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #4117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4117   +/-   ##
=======================================
  Coverage   40.59%   40.59%           
=======================================
  Files         483      483           
  Lines        5747     5747           
  Branches      770      770           
=======================================
  Hits         2333     2333           
  Misses       3042     3042           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6de989...3c0d3c1. Read the comment docs.

@libetl
Copy link
Member

libetl commented Sep 5, 2018

👍

@Hypnosphi
Copy link
Member Author

@libetl I've invited you to the team to make your review matter =)

Feel free to review other PRs and merge already approved ones

@ndelangen
Copy link
Member

ndelangen commented Sep 6, 2018

thanks @Hypnosphi I thought I already had added @libetl.

@libetl
Copy link
Member

libetl commented Sep 6, 2018

Thanks @ team

@ndelangen
Copy link
Member

Merge it @libetl ;)

@Hypnosphi Hypnosphi merged commit f655aa7 into master Sep 6, 2018
@Hypnosphi Hypnosphi deleted the missing-babel-dep branch September 6, 2018 11:21
@Hypnosphi
Copy link
Member Author

Released as 4.0.0-alpha.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants