Add additional device options to addon-viewport #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3918 +/- ##
=======================================
Coverage 41.55% 41.55%
=======================================
Files 455 455
Lines 5179 5179
Branches 899 899
=======================================
Hits 2152 2152
Misses 2487 2487
Partials 540 540
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jul 25, 2018
ndelangen
added
feature request
addon: viewport
patch:yes
|
Thank you @camel-floss! |
Keraito
reviewed
Jul 25, 2018
|
@Keraito I am not sure it matters, but consistency-wise it hurts my eyes. |
|
@igor-dv Done! |
igor-dv
approved these changes
Jul 25, 2018
|
Wow super quick @camel-floss 👏 |
mshaaban088
reviewed
Jul 31, 2018
| @@ -40,6 +40,22 @@ export const INITIAL_VIEWPORTS = { | |||
| }, | |||
| type: 'mobile', | |||
| }, | |||
| iphone8p: { | |||
| name: 'iPhone 7 Plus', | |||
There was a problem hiding this comment.
You mean iPhone 8 Plus, right?
|
This works on top of #3099 so it can't go to 3.4 release, sorry |
Hypnosphi
removed
the
patch:yes
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3915
What I did
Added iPhone, iPad, Samsung Galaxy and Google Pixel models to the list of devices in
addon-viewportHow to test
I spun up the
html-kitchen-sinkexample and was able to see the new devices and sizes.