Removed usages of hoc-style addons from the docs #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
requested review from
dangreenisrael,
danielduan,
Hypnosphi,
ndelangen,
shilman,
theinterned,
usulpro and
z4o4z
as code owners
|
Perhaps @tsiq-swyx might take a look at the typescript changes. I think they are sensible. |
tmeasday
commented
Jul 6, 2018
| info: { | ||
| TableComponent, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Note that this line is the only actual change in this file, it seems prettier has started formatting it.
| .add('With Markdown', withMarkdownNotes(someMarkdownText)(() => <MyComponent/>)); | ||
| storiesOf('Component', module).add('With Markdown', () => <MyComponent />, { | ||
| notes: { markdown: someMarkdownText }, | ||
| }); |
There was a problem hiding this comment.
Again, this is the only actual change in this file.
Codecov Report
@@ Coverage Diff @@
## master #3845 +/- ##
=======================================
Coverage 41.32% 41.32%
=======================================
Files 455 455
Lines 5193 5193
Branches 903 903
=======================================
Hits 2146 2146
Misses 2501 2501
Partials 546 546Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Some docs files still used
withX(options)(story)style addon-usage. In particular,notesandinfoWhat I did
Change to use parameter-based API.
How to test
Verify that the code samples work.