Improvements to Info Docgen parsing #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuweiweiwu
previously requested changes
Jun 18, 2018
danielduan
requested review from
Hypnosphi,
ndelangen and
stijnkoopal
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3772 +/- ##
======================================
Coverage 41% 41%
======================================
Files 453 453
Lines 5097 5097
Branches 858 858
======================================
Hits 2090 2090
Misses 2491 2491
Partials 516 516Continue to review full report at Codecov.
|
ndelangen
approved these changes
Jun 19, 2018
ndelangen
added
the
patch:yes
|
@ndelangen 3.4 is still on docgen plugin v1, so we probably shouldn't apply this patch there |
Hypnosphi
removed
the
patch:yes
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
storybookjs/babel-plugin-react-docgen#51
storybookjs/babel-plugin-react-docgen#54
What I did
Bring in changes to
babel-plugin-react-docgenso Info addon is more complete and accurateHow to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]