Use find-babel-config for the babel config lookup #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shortcuts to jump to previous and next stories
Also added some checks for react-hmre existance and removed it. It doesn't work well with React Storybook and we don't need it.
* Add NPM2 support. With the use alot of require.resolve and defining the missing redux dependency. * Fix lint issues. * Update storybook-ui which is optimized for NPM2
* Use @kadira/storybook-channel module * Update channel addons
Add mthuret/storybook-addon-specifications to extension list in docs/extensions.md
Add new item to extension list
find-babel-config searches for the configuration in the closest .babelrc or package.json file
This was referenced Apr 15, 2021
This was referenced Aug 17, 2021
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 55fa78c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #293. The module
find-babel-configsearches for the closest babel configuration (.babelrcor babel inpackage.json) starting in a specified directory.I've tested the code against the react-storybook-demo and everything looks fine. I checked that the path was correct and the check
inConfigDiris also correct based on the found configuration.