Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exact versions for cross-dependencies between our own packages #3183

Merged
merged 5 commits into from
Mar 10, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3178

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #3183 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3183      +/-   ##
==========================================
- Coverage   36.03%   36.02%   -0.01%     
==========================================
  Files         437      437              
  Lines        9464     9465       +1     
  Branches      885      890       +5     
==========================================
  Hits         3410     3410              
- Misses       5488     5490       +2     
+ Partials      566      565       -1
Impacted Files Coverage Δ
lib/cli/lib/helpers.js 0% <0%> (ø) ⬆️
app/polymer/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
.../src/modules/ui/components/stories_panel/header.js 29.62% <0%> (ø) ⬆️
addons/knobs/src/components/GroupTabs.js 30.48% <0%> (ø) ⬆️
addons/info/src/components/types/PrettyPropType.js 86% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
lib/components/src/table/cell.js 65.21% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
addons/actions/src/lib/reviver.js 58.33% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44060c...cb45ad8. Read the comment docs.

…ncies

# Conflicts:
#	addons/notes/package.json
@ndelangen
Copy link
Member

Makes sense

@Hypnosphi Hypnosphi merged commit 6f4fc3e into master Mar 10, 2018
@Hypnosphi Hypnosphi deleted the exact-cross-dependencies branch March 10, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants