Added missing key prop to NoTests component. #3111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
React is returning a warning about a missing
key
prop when rendering some Jest test results using theNoTests
component (ie. tests could not be found).What I did
Add a
key
prop toNoTests
containing the value of the name of the test being rendered.How to test
Add references to Jest test files inside
withTests
that are not yet present. For example,withTests('somenoneexistenttestsfilename')
.Is this testable with jest or storyshots?
Jest
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.