Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use exact versions in peerDependencies #3073

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Don't use exact versions in peerDependencies #3073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c2ec68
Don't use exact versions in peerDependencies
Hypnosphi Feb 24, 2018
8c56338
Merge remote-tracking branch 'origin/master' into peer-deps-wildcard
Hypnosphi Feb 25, 2018
29d7bd4
Merge branch 'master' into peer-deps-wildcard
Hypnosphi Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@
"babel-core": "^6.26.0 || ^7.0.0-0",
"babel-runtime": ">=6.0.0",
"react": "*",
"react-native": "0.52.2"
"react-native": ">=0.51.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rn is actually pretty tricky to upgrade. it needs matched versions of all the tooling as well for everything to bundle, compile, and work. I still think this is the right move though.

}
}
6 changes: 3 additions & 3 deletions app/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@
"peerDependencies": {
"babel-core": "^6.26.0 || ^7.0.0-0",
"babel-runtime": ">=6.0.0",
"vue": "2.5.13",
"vue-loader": "13.7.1",
"vue-template-compiler": "2.5.13"
"vue": ">=2.0.0",
"vue-loader": ">=13.0.0",
"vue-template-compiler": ">=2.0.0"
}
}