UI: Keep failing stories in the sidebar, disregarding filters #30086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Dec 17, 2024
shilman
reviewed
Dec 17, 2024
|
There is not. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dfe06f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+271
to
+273
| expect(Object.keys(result)).toHaveLength(2); | ||
| expect(result['story-1']).toBeTruthy(); | ||
| expect(result['1']).toBeTruthy(); |
There was a problem hiding this comment.
logic: Test is asserting both 'story-1' and '1' keys exist, but this seems incorrect - should only be checking for one ID format based on the transformation logic
| Object.values(filters).forEach((filter: any) => { | ||
| if (result === false) { | ||
| return; | ||
| } | ||
| result = filter({ ...entry, status: status[entry.id] }); | ||
| result = filter({ ...entry, status: storyStatus }); |
There was a problem hiding this comment.
style: Passing storyStatus directly instead of spreading entry and adding status separately would be more efficient
7 tasks
shilman
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29653
What I did
Before applying filters to the index, we first check if the entry has a failing status. If it does, always keep it in the filtered index.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Modified the story filtering logic to ensure failing stories remain visible in the sidebar regardless of applied filters.
code/core/src/manager-api/lib/stories.tsto preserve stories with error statuscode/core/src/manager-api/lib/stories.test.tsverifying failing stories remain visible despite filters'dev'tag can't be seen in the sidebar #29653 where failing stories without 'dev' tag were hidden from sidebar