-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Test: Prompt switch to experimental-nextjs-vite
#29814
Addon Test: Prompt switch to experimental-nextjs-vite
#29814
Conversation
…adding experimental-addon-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b60cec0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
… when asking user to migrate
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
experimental-nextjs-vite
experimental-nextjs-vite
Closes #29796
What I did
When the postinstall runs of
experimental-addon-test
and the user is using frameworknextjs
prompt them to change toexperimental-nexjs-vite
framework.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This
postinstall
is ran withyes=true
in our CI.It's used to "migrate" the
experimental-nextjs-vite-default-ts
sandbox already.I've manually run the same on my machine locally, and verified the steps are executed, and the sandbox's
main.ts
file andpackage.json
files are modified correctly.QA should include generating a nextjs sandbox WITHOUT the test addon, then adding the test addon to it.
It should ask you to migrate to the experimental framework nextjs vite.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR adds functionality to prompt users to migrate from @storybook/nextjs to @storybook/experimental-nextjs-vite during the experimental-addon-test installation process, ensuring proper test addon functionality.
postinstall.ts
to switch frameworks when Next.js is detected@storybook/experimental-nextjs-vite
and removing@storybook/next