Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNW-Vite: Integrate with experimental-addon-test #29645

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 18, 2024

Closes N/A

What I did

  • Add a new vite-plugin entry point
  • Use that entry point in the experimental-addon-test postinstall

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Here's how I tested:

  1. Created a new sandbox of type react-native-web/vite-expo-ts in dev --no-link mode
  2. After the sandbox is created, and while dev is still running, in a separate terminal
cd sandbox/react-native-web-vite-expo-ts
npx storybok add @storybook/experimental-addon-test
yarn vitest

The tests don't all pass, but many of them do.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.5 MB 78.4 MB -57.4 kB 0.71 -0.1%
initSize 144 MB 144 MB -57.4 kB 0.72 0%
diffSize 65.2 MB 65.2 MB 0 B 1.45 0%
buildSize 6.87 MB 6.88 MB 3.33 kB 1.05 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB 0 B 0.97 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB 0 B 0.97 0%
buildPreviewSize 2.99 MB 3 MB 3.33 kB 0.9 0.1%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 13.2s 25.4s 12.1s 1.55 🔺47.8%
generateTime 35.1s 20.8s -14s -218ms -0.36 -68.1%
initTime 15.3s 13.8s -1s -520ms -0.88 -11%
buildTime 8.8s 8.7s -119ms 0.01 -1.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6s 6.3s 279ms 1.11 4.4%
devManagerResponsive 3.7s 3.8s 121ms 0.67 3.1%
devManagerHeaderVisible 513ms 602ms 89ms 0.58 14.8%
devManagerIndexVisible 580ms 684ms 104ms 0.69 15.2%
devStoryVisibleUncached 932ms 1.1s 202ms 0.68 17.8%
devStoryVisible 547ms 679ms 132ms 0.93 19.4%
devAutodocsVisible 540ms 527ms -13ms 0.38 -2.5%
devMDXVisible 515ms 536ms 21ms 0.52 3.9%
buildManagerHeaderVisible 567ms 549ms -18ms -0.28 -3.3%
buildManagerIndexVisible 577ms 572ms -5ms -0.21 -0.9%
buildStoryVisible 565ms 550ms -15ms -0.25 -2.7%
buildAutodocsVisible 456ms 480ms 24ms -0.12 5%
buildMDXVisible 412ms 447ms 35ms 0.04 7.8%

@shilman shilman added feature request ci:daily Run the CI jobs that normally run in the daily job. addon: test react-native-web labels Nov 18, 2024
Copy link

nx-cloud bot commented Nov 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b6d5391. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member Author

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-merging @kasperpeulen

@shilman shilman merged commit 71c3c5c into next Nov 18, 2024
109 of 113 checks passed
@shilman shilman deleted the shilman/rnw-integrate-addon-test branch November 18, 2024 18:08
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: test ci:daily Run the CI jobs that normally run in the daily job. feature request react-native-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant