Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 8.4.2 #29510

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Release: Patch 8.4.2 #29510

merged 7 commits into from
Nov 5, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2024

This is an automated pull request that bumps the version from 8.4.1 to 8.4.2.
Once this pull request is merged, it will trigger a new release of version 8.4.2.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Addon Test: Only render the TestingModule component in development mode #29501
  • 🐛 Bug: Next.js: Fix bundled react and react-dom in monorepos #29444
  • 🐛 Bug: CLI: Fix Solid init by installing @storybook/test #29514
  • 🐛 Bug: Core: Shim CJS-only globals in ESM output #29157
  • 🐛 Bug: Addon Test: Fix post-install logic for Next.js Vite framework support #29524

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.4.2

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Nov 1, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.1 branch 2 times, most recently from 30c05fd to 0b7b0d1 Compare November 2, 2024 02:39
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.1 branch 4 times, most recently from baa6ddb to 9aa3e0e Compare November 4, 2024 16:00
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. and removed ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label labels Nov 5, 2024
Copy link

nx-cloud bot commented Nov 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1d10e77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

yannbf and others added 6 commits November 5, 2024 02:28
…n-prod

Addon Test: Only render the TestingModule component in development mode

(cherry picked from commit 46e37f1)
…norepo

Next.js: Fix bundled react and react-dom in monorepos

(cherry picked from commit 6c829c5)
CLI: Fix Solid init by installing `@storybook/test`
(cherry picked from commit d130f0c)
…lugin

Build: Shim CJS-only globals in ESM output
(cherry picked from commit 3b5851a)
…it-in-experimental-nextjs-vite

Addon Test: Enhance post-install logic for Next.js Vite framework support

(cherry picked from commit 18aaf10)
@shilman shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Nov 5, 2024
@shilman shilman merged commit 12d2737 into latest-release Nov 5, 2024
109 of 112 checks passed
@shilman shilman deleted the version-patch-from-8.4.1 branch November 5, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants