Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octobooth 1 patch 1 #29493

Closed
wants to merge 2 commits into from

Conversation

octobooth-1
Copy link

@octobooth-1 octobooth-1 commented Oct 30, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Based on the provided files and context, here's my review of the pull request:

This PR adds lodash v3.10.1 as a direct dependency to Storybook's root package.json, which is concerning given this version is from 2015 and significantly outdated.

  • Adding lodash v3.10.1 introduces potential security vulnerabilities as this version is ~8 years old
  • The PR appears unrelated to the referenced issues about ESLint rules (Set ESlint rules more strict 🚑 #1000) and TypeScript types (Fix for types number for addon knobs #1001)
  • Using such an old version of lodash could conflict with modern JavaScript features and other dependencies
  • The change lacks justification for why this specific outdated version is needed
  • No tests or documentation updates are included to validate this dependency addition

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -200,6 +200,7 @@
"http-server": "^14.1.1",
"husky": "^4.3.7",
"lint-staged": "^13.2.2",
"lodash": "3.10.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Using lodash v3.10.1 from 2015 introduces security vulnerabilities. Should use latest 4.x version instead.

@octobooth-1 octobooth-1 deleted the octobooth-1-patch-1 branch October 30, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant