Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better examples separation #2918

Merged
merged 18 commits into from
Feb 16, 2018
Merged

Better examples separation #2918

merged 18 commits into from
Feb 16, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Feb 5, 2018

Issue: I would like to have a better examples/documentation for the supported frameworks.

What I did

image

CC: #2885

@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #2918 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2918      +/-   ##
==========================================
+ Coverage   37.35%   37.37%   +0.01%     
==========================================
  Files         426      426              
  Lines        9150     9151       +1     
  Branches      884      883       -1     
==========================================
+ Hits         3418     3420       +2     
+ Misses       5182     5181       -1     
  Partials      550      550
Impacted Files Coverage Δ
app/polymer/src/server/config/babel.prod.js 0% <ø> (ø) ⬆️
addons/background/src/BackgroundPanel.js 93.93% <0%> (+1.63%) ⬆️
addons/background/src/index.js 86.36% <0%> (+6.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb9a84...9a070ac. Read the comment docs.

@igor-dv
Copy link
Member Author

igor-dv commented Feb 6, 2018

image

@igor-dv igor-dv added the vue label Feb 6, 2018
@igor-dv igor-dv changed the title Better examples separation for angular Better examples separation Feb 6, 2018
@igor-dv
Copy link
Member Author

igor-dv commented Feb 6, 2018

image

@tmeasday
Copy link
Member

@igor-dv -- the snapshot changes are nothing to do with this branch; there's a problem with this technique of opening an iframe. See #2958 (comment)

@codecov-io
Copy link

Codecov Report

Merging #2918 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2918   +/-   ##
=======================================
  Coverage   37.35%   37.35%           
=======================================
  Files         426      426           
  Lines        9150     9150           
  Branches      881      884    +3     
=======================================
  Hits         3418     3418           
- Misses       5171     5174    +3     
+ Partials      561      558    -3
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
lib/ui/src/modules/ui/containers/stories_panel.js 27.02% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/search_box.js 23.52% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/core/src/client/preview/reducer.js 37.5% <0%> (ø) ⬆️
addons/info/src/components/makeTableComponent.js 67.46% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/routed_link.js 22.72% <0%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9f6c0...f75b3c3. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 5871574 into master Feb 16, 2018
@Hypnosphi Hypnosphi deleted the better-examples-separation branch February 16, 2018 18:59
@igor-dv
Copy link
Member Author

igor-dv commented Feb 17, 2018

Oh thanks, @Hypnosphi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants