Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Add the globals export for manager #28650

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 18, 2024

Closes #28647

What I did

Add the globals export for manager, the addon-kit uses it

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.5 MB 0 B 1.21 0%
initSize 198 MB 198 MB 12.4 kB -0.4 0%
diffSize 121 MB 121 MB 12.4 kB -0.42 0%
buildSize 7.59 MB 7.6 MB 2.45 kB 38.59 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 2.91 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 2.45 kB 6117 0.1%
buildSbPreviewSize 349 kB 349 kB 0 B 3 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 2.45 kB 48.67 0.1%
buildPreviewSize 3.12 MB 3.12 MB 0 B 2.38 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 9.1s 23.3s 14.2s 1.53 🔺60.7%
generateTime 21.8s 21.1s -654ms -0.68 -3.1%
initTime 23.5s 20.4s -3s -143ms -1.57 🔰-15.4%
buildTime 14.6s 12.9s -1s -676ms -1.29 🔰-12.9%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8s 8.3s 352ms -0.07 4.2%
devManagerResponsive 5.5s 5.7s 179ms 0.45 3.1%
devManagerHeaderVisible 874ms 739ms -135ms -1.15 -18.3%
devManagerIndexVisible 898ms 771ms -127ms -1.13 -16.5%
devStoryVisibleUncached 1.1s 1.1s -3ms -0.98 -0.3%
devStoryVisible 914ms 792ms -122ms -1.15 -15.4%
devAutodocsVisible 809ms 743ms -66ms 0.11 -8.9%
devMDXVisible 706ms 643ms -63ms -1.8 🔰-9.8%
buildManagerHeaderVisible 1.1s 720ms -399ms -0.7 -55.4%
buildManagerIndexVisible 1.1s 722ms -420ms -0.7 -58.2%
buildStoryVisible 1.1s 770ms -428ms -0.71 -55.6%
buildAutodocsVisible 1s 650ms -428ms -0.71 -65.8%
buildMDXVisible 786ms 682ms -104ms -0.07 -15.2%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added src/manager/globals.ts entry in code/core/scripts/entries.ts
  • Added code/deprecated/manager/globals.js for backward compatibility
  • Added code/deprecated/preview/globals.js for consistent export path
  • Added globals.cjs, globals.d.ts, and globals.js in code/lib/cli/core/manager for addon-kit support

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cbac722. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 18, 2024
@ndelangen ndelangen merged commit 0c91f47 into next Jul 18, 2024
59 of 62 checks passed
@ndelangen ndelangen deleted the norbert/cpc-backwards-support-for-addon-kit branch July 18, 2024 21:36
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
12 tasks
storybook-bot pushed a commit that referenced this pull request Jul 18, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
13 tasks
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
storybook-bot pushed a commit that referenced this pull request Jul 19, 2024
…ort-for-addon-kit

CPC: Add the globals export for manager
(cherry picked from commit 0c91f47)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Addon build fails due to missing @storybook/manager/globals on 8.2.x
2 participants