-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files knob #2860
Merged
Merged
files knob #2860
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9d4aecc
first pass at files knob type
kn0ll 1f3a011
adding files to all knobs story
kn0ll 59d1286
updating readme
kn0ll 37258a5
importing filereader from global
kn0ll 30be96e
accept attribute
kn0ll 95881f2
adding files knob import/export to polymer and vue files (untested)
kn0ll 2b67e01
adding knobs examples to examples/official-storybook
kn0ll ab8a566
Merge branch 'master' into files-knob
ndelangen bc2c3da
Merge remote-tracking branch 'origin/master' into files-knob
Hypnosphi b57e8e7
Fix lint and tests
Hypnosphi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { FileReader } from 'global'; | ||
import PropTypes from 'prop-types'; | ||
import React from 'react'; | ||
|
||
function fileReaderPromise(file) { | ||
return new Promise(resolve => { | ||
const fileReader = new FileReader(); | ||
fileReader.onload = e => resolve(e.currentTarget.result); | ||
fileReader.readAsDataURL(file); | ||
}); | ||
} | ||
|
||
const FilesType = ({ knob, onChange }) => ( | ||
<input | ||
id={knob.name} | ||
type="file" | ||
multiple | ||
onChange={e => Promise.all(Array.from(e.target.files).map(fileReaderPromise)).then(onChange)} | ||
accept={knob.accept} | ||
/> | ||
); | ||
|
||
FilesType.defaultProps = { | ||
knob: {}, | ||
onChange: value => value, | ||
}; | ||
|
||
FilesType.propTypes = { | ||
knob: PropTypes.shape({ | ||
name: PropTypes.string, | ||
}), | ||
onChange: PropTypes.func, | ||
}; | ||
|
||
FilesType.serialize = () => undefined; | ||
FilesType.deserialize = () => undefined; | ||
|
||
export default FilesType; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be handy to be able to pass
accept
atribute herehttps://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Limiting_accepted_file_types