Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Setting globals on a story #27705

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 5, 2024

Closes N/A

Telescoping on (PR TBD)

What I did

Add documentation for setting globals on a story/component

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman added documentation ci:docs Run the CI jobs for documentation checks only. labels Jun 5, 2024
Copy link

nx-cloud bot commented Jun 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4265010. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman marked this pull request as ready for review June 7, 2024 17:22
@shilman shilman changed the title Document setting globals on a story Documentation: Setting globals on a story Jun 7, 2024
@kylegach kylegach self-assigned this Jun 8, 2024
@ndelangen ndelangen requested a review from jonniebigodes August 1, 2024 15:02
@ndelangen ndelangen changed the base branch from tom/23347-toolbars-overrides to tom/23347-story-globals August 1, 2024 15:04
@ndelangen ndelangen requested a review from kylegach as a code owner August 1, 2024 15:04
@ndelangen ndelangen changed the base branch from tom/23347-story-globals to tom/23347-toolbars-overrides August 1, 2024 15:05
@ndelangen
Copy link
Member

We're going to take these changes and apply them manually to this PR instead:
#28716

@ndelangen ndelangen closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants