Telemetry: Add test packages #27226
Merged
Telemetry: Add test packages #27226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
maintenance
shilman
force-pushed
the
shilman/test-package-telemetry
branch
from
3289fec to
59631c9
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6fe4e7f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
shilman
force-pushed
the
shilman/test-package-telemetry
branch
2 times, most recently
from
16bea95 to
dbac3f7
Compare
yannbf
reviewed
May 22, 2024
| ); | ||
| metadata.testPackages = Object.fromEntries( | ||
| await Promise.all( | ||
| testPackageDeps.map(async (dep) => [dep, (await getActualPackageVersion(dep))?.version]) |
There was a problem hiding this comment.
You might want to filter the packages out like anything that includes plugin, preset or addon. Else you might get a bunch of noise
yannbf
approved these changes
May 22, 2024
shilman
force-pushed
the
shilman/test-package-telemetry
branch
from
dbac3f7 to
6fe4e7f
Compare
storybook-bot
pushed a commit
that referenced
this pull request
May 22, 2024
…etry Telemetry: Add test packages (cherry picked from commit e812f77)
This was referenced May 22, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
May 23, 2024
…etry Telemetry: Add test packages (cherry picked from commit e812f77)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Track which testing packages Storybook is being used with, so that we can help prioritize integrations.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
In a sandbox:
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>