-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix : summary: undefined
type issue
#27202
base: next
Are you sure you want to change the base?
Bugfix : summary: undefined
type issue
#27202
Conversation
I've cloned your repository, how can I test this from a project using storybook ? I guess I need to replace the version used by the local repo I cloned, but I've never done that. Could you share some pointers ? :) |
@Hyzual I have created a canary release. You can try it out by upgrading Storybook to it:
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b3cb3f7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TypeScript error is still present. We have found that we had to modify an interface named InputType
from the @storybook/types
package to add string | undefined
for the TypeScript error to be fixed. I tried looking for it in the code but did not find it 😓. If you know where it is and could change it, I would be grateful!
@shilman I've opened a pull request at ComponentDriven/csf#94. Thanks a lot for the pointers! |
Closes #27129
What I did
I've updated the type for
ArgType.table.type.summary
to bestring | undefined
so as to enableexactOptionalPropertyTypes: true
intsconfig.json
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-27202-sha-9b58ef19
. Try it out in a new sandbox by runningnpx [email protected] sandbox
or in an existing project withnpx [email protected] upgrade
.More information
0.0.0-pr-27202-sha-9b58ef19
undefined-support-for-argtype
9b58ef19
1716367928
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=27202