Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add "React peer dependency is no longer required" section to addon migration guide #25826

Merged
merged 9 commits into from
Feb 20, 2024

Conversation

vanessayuenn
Copy link
Contributor

What I did

Added the bit about addon now can remove their react peer dependency.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No need!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@vanessayuenn vanessayuenn added documentation ci:docs Run the CI jobs for documentation checks only. labels Jan 30, 2024
@vanessayuenn vanessayuenn marked this pull request as ready for review January 30, 2024 22:04
@vanessayuenn vanessayuenn requested a review from yannbf January 31, 2024 14:42
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanessayuenn appreciate you taking the time to put together this pull request and help improve the documentation 🙏 ! I left a small item for you to look into when you have a moment.

Let me know of any questions you may have so we can address them and make this available to our users.

Have a great day.

Stay safe

docs/addons/addon-migration-guide.md Show resolved Hide resolved
@JReinhold
Copy link
Contributor

@vanessayuenn @jonniebigodes I added a section referencing the addon kit changes as a migration example.

@jonniebigodes
Copy link
Contributor

@vanessayuenn I left a suggestion for @JReinhold to look into for the migration example. However, the pull request that superseded this one was approved and merged without me having a chance to look into it, and this introduced some documentation issues that could have been easily prevented. Once this is merged, I'll do a proper vetting and polish this to get it into a good state and avoid any follow-up pull requests further down the line.

@vanessayuenn
Copy link
Contributor Author

@jonniebigodes i will be merging this for now as this PR contains crucial information for addon authors to migrate. Please do the polishing separately though! Appreciate your help here ❤️ .

@vanessayuenn vanessayuenn merged commit e7a965e into next Feb 20, 2024
18 checks passed
@vanessayuenn vanessayuenn deleted the vy/addon-migration-guide-8 branch February 20, 2024 19:06
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants