Build: Ignore changing version in SvelteKit story
#25241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code/frameworks/sveltekit/template/stories_svelte-kit-skeleton-ts/Environment.svelte
Show resolved
Hide resolved
shilman
force-pushed
the
shilman/fix-sveltekit-environment-story
branch
from
9f24b21 to
05efeae
Compare
shilman
changed the title
version from SvelteKit environment storyversion in SvelteKit story
storybook-bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
Merged
10 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
22 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
…ronment-story Build: Ignore changing `version` in SvelteKit story (cherry picked from commit 5854e5a)
github-actions
bot
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
The
versionenvironment variable seems to change across builds so it shows up as a chromatic diff. I removed it to avoid false positives.Example: https://www.chromatic.com/test?appId=634ff621f2a0d0f01971eae7&id=657bc3b34892b800b040fd32
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>