-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Fix CSF Plugin #25098
Merged
valentinpalkovic
merged 4 commits into
next
from
valentin/fix-csf-loader-for-angular-second-attempt
Dec 4, 2023
Merged
Angular: Fix CSF Plugin #25098
valentinpalkovic
merged 4 commits into
next
from
valentin/fix-csf-loader-for-angular-second-attempt
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
ci:daily
Run the CI jobs that normally run in the daily job.
bug
angular
labels
Dec 4, 2023
valentinpalkovic
force-pushed
the
valentin/fix-csf-loader-for-angular-second-attempt
branch
from
December 4, 2023 07:47
208ac2b
to
ca523d3
Compare
valentinpalkovic
force-pushed
the
valentin/fix-csf-loader-for-angular-second-attempt
branch
from
December 4, 2023 08:04
ca523d3
to
cdb5079
Compare
valentinpalkovic
requested review from
kasperpeulen,
shilman and
ndelangen
as code owners
December 4, 2023 09:12
shilman
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ ❤️ ❤️
This looks so much better!!!
❤️ ❤️ ❤️
shilman
reviewed
Dec 4, 2023
valentinpalkovic
added
ci:normal
ci:daily
Run the CI jobs that normally run in the daily job.
patch:yes
Bugfix & documentation PR that need to be picked to main branch
and removed
ci:daily
Run the CI jobs that normally run in the daily job.
ci:normal
labels
Dec 4, 2023
valentinpalkovic
deleted the
valentin/fix-csf-loader-for-angular-second-attempt
branch
December 4, 2023 20:39
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
This was referenced Dec 4, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
44 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…r-angular-second-attempt Angular: Fix CSF Plugin (cherry picked from commit 96bcc58)
github-actions
bot
added
patch:done
Patch/release PRs already cherry-picked to main/release branch
labels
Dec 7, 2023
8 tasks
kasperpeulen
restored the
valentin/fix-csf-loader-for-angular-second-attempt
branch
January 11, 2024 15:30
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
angular
bug
ci:daily
Run the CI jobs that normally run in the daily job.
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21387, #17233, #24241, #20475, #14043
What I did
The CSF Plugin was reading the source file from the filesystem instead of processing it as a loader within a loader chain. The transformations applied by the CSF Plugin overrode any processing that had occurred before. Angular for instance does also access the filesystem directly to transform files. The CSF loader therefore has to be applied at a later point. This requires the CSF loader to apply the necessary transformations on already transformed files. The loader has to read the original source file, though, to get the source code before any other transformer touches it (prevent removed comments or transformed code).
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Test that JSON comments are preserved
?path=/docs/addons-docs-docspage-basic--docs
storyStorysource
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>