Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add missing barHoverColor in theme common snippet #25051

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Docs: Add missing barHoverColor in theme common snippet #25051

merged 2 commits into from
Dec 5, 2023

Conversation

julien-deramond
Copy link
Contributor

What I did

This PR adds barHoverColor to the theme common snippet.

Apparently, this snippet references all the theme variables available and is rendered in https://storybook.js.org/docs/configure/theming#create-a-theme-quickstart to help create a theme.

I can see this kind of modification was done at the same time as the addition of appPreviewBg recently. And this is something I missed when I added barHoverColor in #20169.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@julien-deramond julien-deramond marked this pull request as ready for review November 30, 2023 07:07
@valentinpalkovic valentinpalkovic added documentation ci:docs Run the CI jobs for documentation checks only. labels Dec 4, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-deramond, thanks for putting together this pull request and helping us improve the documentation by following up on your previous contribution and making it available to our users. We appreciate it 🙏 !

I've checked, and all is good on my end. More than glad to merge this in once the checklist clears.

Hope you have a fantastic day.

Stay safe

@jonniebigodes jonniebigodes changed the title Add missing barHoverColor in theme common snippet Docs: Add missing barHoverColor in theme common snippet Dec 5, 2023
@jonniebigodes jonniebigodes merged commit dfb4aac into storybookjs:next Dec 5, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants