Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Minor Fixes and cleanup #25048

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Docs: Minor Fixes and cleanup #25048

merged 2 commits into from
Nov 29, 2023

Conversation

jonniebigodes
Copy link
Contributor

Closes #24713

What I did

With this pull request the documentation was updated to factor in the latest changes added as part of the docs restructuring and some minor cleanup in terms of snippets

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Nov 29, 2023
@jonniebigodes jonniebigodes self-assigned this Nov 29, 2023
@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 29, 2023
@jonniebigodes
Copy link
Contributor Author

Heads up, I'm going to go ahead as most of the feedback obtained in the mentioned pull request was factored in here.

@jonniebigodes jonniebigodes merged commit dbc4f02 into next Nov 29, 2023
18 checks passed
@jonniebigodes jonniebigodes deleted the docs_minor_cleanuo branch November 29, 2023 21:48
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
36 tasks
storybook-bot pushed a commit that referenced this pull request Nov 30, 2023
Docs: Minor Fixes and cleanup
(cherry picked from commit dbc4f02)
@github-actions github-actions bot mentioned this pull request Nov 30, 2023
8 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant