Vite: Fix Vite 5 CJS warnings #25005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
# Conflicts: # code/frameworks/vue-vite/src/plugins/vue-docgen.ts # code/frameworks/vue-vite/src/preset.ts
kasperpeulen
requested review from
cdedreuille,
kasperpeulen,
yannbf,
valentinpalkovic,
IanVS and
ndelangen
as code owners
valentinpalkovic
approved these changes
Jan 3, 2024
15 tasks
IanVS
reviewed
Jan 3, 2024
| @@ -39,6 +39,18 @@ module.exports = { | |||
| allowIndexSignaturePropertyAccess: true, | |||
| }, | |||
| ], | |||
| '@typescript-eslint/no-restricted-imports': [ | |||
| @@ -140,11 +140,12 @@ export function getOptions<TOptions extends OptionSpecifier>( | |||
|
|
|||
| const checkStringValue = (raw: string) => { | |||
| if (option.values && !option.values.includes(raw)) { | |||
| const possibleOptions = chalk.cyan(option.values.join(', ')); | |||
| const possibleOptions = chalk.cyan(option.values.join('\n')); | |||
There was a problem hiding this comment.
This change seems unrelated to this PR, was it intentional?
There was a problem hiding this comment.
Unrelated, but intentional. The message was pretty unreadable, so I just quickly improved it slightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work on #24333
What I did
Converted a number of
'vite'imports to be dynamic imports, to force the use of Vite's ESM bundle.Also added an ESLint rule to enforce this behavior going forward.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>