-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js: Add next/font/local declarations support #24983
Merged
valentinpalkovic
merged 9 commits into
storybookjs:next
from
MauricioRobayo:next-font-local-declarations-support
Dec 4, 2023
Merged
Next.js: Add next/font/local declarations support #24983
valentinpalkovic
merged 9 commits into
storybookjs:next
from
MauricioRobayo:next-font-local-declarations-support
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauricioRobayo
changed the title
add next-font-local-declarations-support
next/font/local declarations support
Nov 25, 2023
MauricioRobayo
requested review from
valentinpalkovic,
kasperpeulen and
yannbf
as code owners
November 25, 2023 16:30
valentinpalkovic
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Well done.
LGTM!
valentinpalkovic
changed the title
next/font/local declarations support
Next.js: Add next/font/local declarations support
Dec 1, 2023
valentinpalkovic
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Dec 4, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
This was referenced Dec 4, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
44 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…tions-support Next.js: Add next/font/local declarations support (cherry picked from commit 0327b57)
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:normal
nextjs
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #24979 (reply in thread)
What I did
Add support for next/font/local declarations.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
ascent-override: 500%
tolocalRubikStorm
local font on thecode/frameworks/nextjs/template/stories_nextjs-default-js/Font.jsx
file.export const localRubikStorm = localFont({ src: '/fonts/RubikStorm-Regular.ttf', variable: '--font-rubik-storm', + declarations: [{ prop: 'ascent-override', value: '500%' }], });
nexjs/default-js
sandbox:/story/stories-frameworks-nextjs-nextjs-default-js-font--with-class-name
story and select the text for the local font, you should be able to see how the ascent for the font was modified:Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>