Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Add next/font/local declarations support #24983

Conversation

MauricioRobayo
Copy link
Contributor

@MauricioRobayo MauricioRobayo commented Nov 25, 2023

Discussion: #24979 (reply in thread)

What I did

Add support for next/font/local declarations.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Add ascent-override: 500% to localRubikStorm local font on the code/frameworks/nextjs/template/stories_nextjs-default-js/Font.jsx file.
export const localRubikStorm = localFont({
  src: '/fonts/RubikStorm-Regular.ttf',
  variable: '--font-rubik-storm',
+ declarations: [{ prop: 'ascent-override', value: '500%' }],
});
  1. Start the nexjs/default-js sandbox:
yarn task --task dev --template nextjs/default-js --start-from=sandbox
  1. Got to the /story/stories-frameworks-nextjs-nextjs-default-js-font--with-class-name story and select the text for the local font, you should be able to see how the ascent for the font was modified:
image

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@MauricioRobayo MauricioRobayo changed the title add next-font-local-declarations-support next/font/local declarations support Nov 25, 2023
@MauricioRobayo MauricioRobayo marked this pull request as ready for review November 25, 2023 16:30
@MauricioRobayo MauricioRobayo marked this pull request as draft November 25, 2023 16:38
@MauricioRobayo MauricioRobayo marked this pull request as ready for review November 26, 2023 16:34
Copy link
Contributor

@valentinpalkovic valentinpalkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Well done.
LGTM!

@valentinpalkovic valentinpalkovic changed the title next/font/local declarations support Next.js: Add next/font/local declarations support Dec 1, 2023
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 4, 2023
@valentinpalkovic valentinpalkovic merged commit 0327b57 into storybookjs:next Dec 4, 2023
49 of 50 checks passed
storybook-bot pushed a commit that referenced this pull request Dec 4, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 4, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
@MauricioRobayo MauricioRobayo deleted the next-font-local-declarations-support branch December 4, 2023 13:42
storybook-bot pushed a commit that referenced this pull request Dec 4, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 5, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 5, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 5, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 5, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 5, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 5, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 6, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 6, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 6, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 6, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 6, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
44 tasks
storybook-bot pushed a commit that referenced this pull request Dec 7, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
storybook-bot pushed a commit that referenced this pull request Dec 7, 2023
…tions-support

Next.js: Add next/font/local declarations support

(cherry picked from commit 0327b57)
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants