Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Enable SWC for new Webpack5-based projects #24871

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 16, 2023

Closes #24869

What I did

sb init will set true for the useSWC flag for all new Webpack5-based projects, except for Angular and Next.js

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a Webpack5 sandbox
  2. Go to .storybook/main.<ts|js> and check, whether framework: { builder: { useSWC: true }} is set (except for Angular and Next.js)

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Nov 16, 2023
@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/add-swc-support-for-nextjs November 16, 2023 13:32
@valentinpalkovic valentinpalkovic added feature request ci:daily Run the CI jobs that normally run in the daily job. labels Nov 16, 2023
@valentinpalkovic valentinpalkovic marked this pull request as ready for review November 16, 2023 14:49
@valentinpalkovic valentinpalkovic force-pushed the valentin/use-swc-in-webpack5-projects branch from e3d1357 to 0f4b694 Compare November 20, 2023 08:03
@valentinpalkovic valentinpalkovic force-pushed the valentin/use-swc-in-webpack5-projects branch from 0f4b694 to e0582ad Compare November 20, 2023 08:05
@valentinpalkovic valentinpalkovic force-pushed the valentin/add-swc-support-for-nextjs branch from bcc8e7e to 5021bf4 Compare November 20, 2023 08:05
@valentinpalkovic valentinpalkovic changed the base branch from valentin/add-swc-support-for-nextjs to next November 20, 2023 08:07
@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/add-swc-support-for-nextjs November 20, 2023 08:07
@valentinpalkovic valentinpalkovic force-pushed the valentin/use-swc-in-webpack5-projects branch from e0582ad to f72d5eb Compare November 20, 2023 08:08
@valentinpalkovic valentinpalkovic force-pushed the valentin/use-swc-in-webpack5-projects branch from f72d5eb to 39a2b46 Compare November 20, 2023 08:14
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/jscodeshift 0.11.7...0.11.10 None +0/-0 37.9 kB types

@valentinpalkovic valentinpalkovic merged commit 1c3105a into valentin/add-swc-support-for-nextjs Nov 20, 2023
105 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/use-swc-in-webpack5-projects branch November 20, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust sb init to set useSWC to true for all new Webpack5-based projects, except for Angular
3 participants