-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js: Enable SWC for new Webpack5-based projects #24871
Merged
valentinpalkovic
merged 15 commits into
valentin/add-swc-support-for-nextjs
from
valentin/use-swc-in-webpack5-projects
Nov 20, 2023
Merged
Next.js: Enable SWC for new Webpack5-based projects #24871
valentinpalkovic
merged 15 commits into
valentin/add-swc-support-for-nextjs
from
valentin/use-swc-in-webpack5-projects
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the base branch from
next
to
valentin/add-swc-support-for-nextjs
November 16, 2023 13:32
valentinpalkovic
added
feature request
ci:daily
Run the CI jobs that normally run in the daily job.
labels
Nov 16, 2023
yannbf
reviewed
Nov 16, 2023
yannbf
approved these changes
Nov 16, 2023
valentinpalkovic
force-pushed
the
valentin/use-swc-in-webpack5-projects
branch
from
November 20, 2023 08:03
e3d1357
to
0f4b694
Compare
valentinpalkovic
requested review from
cdedreuille,
JReinhold,
shilman and
tmeasday
as code owners
November 20, 2023 08:03
valentinpalkovic
force-pushed
the
valentin/use-swc-in-webpack5-projects
branch
from
November 20, 2023 08:05
0f4b694
to
e0582ad
Compare
valentinpalkovic
force-pushed
the
valentin/add-swc-support-for-nextjs
branch
from
November 20, 2023 08:05
bcc8e7e
to
5021bf4
Compare
valentinpalkovic
changed the base branch from
valentin/add-swc-support-for-nextjs
to
next
November 20, 2023 08:07
valentinpalkovic
changed the base branch from
next
to
valentin/add-swc-support-for-nextjs
November 20, 2023 08:07
valentinpalkovic
force-pushed
the
valentin/use-swc-in-webpack5-projects
branch
from
November 20, 2023 08:08
e0582ad
to
f72d5eb
Compare
(except for Angular and Next.js)
valentinpalkovic
force-pushed
the
valentin/use-swc-in-webpack5-projects
branch
from
November 20, 2023 08:14
f72d5eb
to
39a2b46
Compare
ndelangen
reviewed
Nov 20, 2023
ndelangen
reviewed
Nov 20, 2023
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
valentinpalkovic
merged commit Nov 20, 2023
1c3105a
into
valentin/add-swc-support-for-nextjs
105 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24869
What I did
sb init
will settrue
for theuseSWC
flag for all new Webpack5-based projects, except for Angular and Next.jsChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
.storybook/main.<ts|js>
and check, whetherframework: { builder: { useSWC: true }}
is set (except for Angular and Next.js)Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>