Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix import path #24338

Merged
merged 2 commits into from
Oct 2, 2023
Merged

docs: fix import path #24338

merged 2 commits into from
Oct 2, 2023

Conversation

YossiSaadi
Copy link
Contributor

What I did

Just a small fix in the documentation.
We're inside manager, and also types are not exported from preview-api.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

No need imo

Manual testing

  1. Go to https://storybook.js.org/docs/react/addons/addons-api#addonsadd
  2. See that preview-api is being used although manager-api should have been used

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes self-assigned this Oct 2, 2023
@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Oct 2, 2023
@jonniebigodes
Copy link
Contributor

@YossiSaadi thanks for taking the time to put together this pull request and help us improve the documentation by catching this small but rather important typo. Appreciate it 🙏 ! I've checked, and all is good on my end. I'll merge this once the checklist clears.

Hope you have a fantastic week.

Stay safe

@jonniebigodes jonniebigodes merged commit 470aa54 into storybookjs:next Oct 2, 2023
8 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
20 tasks
@YossiSaadi YossiSaadi deleted the patch-1 branch October 3, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants