Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix type checking for 3 unit tests #23932

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

mastrzyz
Copy link
Contributor

@mastrzyz mastrzyz commented Aug 23, 2023

What I did

  • Fix function signature in PNPProxy UT
  • Fix type for handleProp UT

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • compiler
  • unit tests
image image image

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@mastrzyz mastrzyz changed the title Fix type checking. Fix type checking for 2 unit tests Aug 23, 2023
@mastrzyz mastrzyz changed the title Fix type checking for 2 unit tests Fix type checking for 3 unit tests Aug 23, 2023
@mastrzyz mastrzyz requested a review from JReinhold as a code owner August 23, 2023 17:14
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Aug 24, 2023
@kasperpeulen kasperpeulen changed the title Fix type checking for 3 unit tests Build: Fix type checking for 3 unit tests Aug 24, 2023
@yannbf
Copy link
Member

yannbf commented Aug 28, 2023

Hey @mastrzyz thanks for your contribution! Seems like the unit tests are failing. Could you take a look into them?

code/addons/links/src/utils.test.ts Outdated Show resolved Hide resolved
@mastrzyz mastrzyz requested a review from ndelangen August 28, 2023 15:50
@yannbf
Copy link
Member

yannbf commented Sep 19, 2023

Hey @ndelangen would you mind checking this out whenever you have time? Thanks!

It might take some time as we are quite busy, we really appreciate your efforts and patience <3

@ndelangen ndelangen merged commit 960154a into storybookjs:next Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants