Addon docs: Add safe check in Webpack preset #23687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
bug
patch:yes
Merged
14 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Addon docs: Add safe check in Webpack preset (cherry picked from commit ac1a3e2)
kasperpeulen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23945
What I did
This PR adds a fix to addon-docs in circumstances where users have custom webpack configs which end up not having
module.rules, and therefore the following error is thrown:How to test
yarn task --task sandbox --start-from auto --template react-webpack/18-tsmodule.rulesIt should not break
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>