E2E: Fix flaky e2e tests #23630
Merged
E2E: Fix flaky e2e tests #23630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
patch:yes
valentinpalkovic
added
patch:yes
valentinpalkovic
force-pushed
the
valentin/fix-flakiness-in-e2e-tests
branch
2 times, most recently
from
13aa8c3
to
a4e3126
Compare
valentinpalkovic
force-pushed
the
valentin/fix-flakiness-in-e2e-tests
branch
from
a4e3126
to
99047dd
Compare
yannbf
reviewed
Jul 31, 2023
ndelangen
approved these changes
Aug 1, 2023
Closed
33 tasks
Merged
14 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…e2e-tests E2E: Fix flaky e2e tests (cherry picked from commit a4feb6b)
kasperpeulen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
This PR attempts to fix the flakyness in the E2E tests, which has been happening quite frequently.
It changes the session storage to make sure that the toolbar and the sidebar are visible before running each test. Most of the flake is related to either of these not being visible when a test is running.
How to test
CI should be green!
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>