Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix svgr snippet in Next.js docs #23621

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Documentation: Fix svgr snippet in Next.js docs #23621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f34110
fix svgr snippet in nextjs docs
yannbf Jul 26, 2023
a99dc70
Merge branch 'next' into yann/fix-nextjs-docs-snippet
yannbf Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions code/frameworks/nextjs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,10 +827,15 @@ Below is an example of how to add svgr support to Storybook with this framework.
export default {
// ...
webpackFinal: async (config) => {
config.module = config.module || {};
config.module.rules = config.module.rules || [];

// This modifies the existing image rule to exclude .svg files
// since you want to handle those files with @svgr/webpack
const imageRule = config.module.rules.find((rule) => rule.test.test('.svg'));
imageRule.exclude = /\.svg$/;
const imageRule = config.module.rules.find((rule) => rule?.['test']?.test('.svg'));
if (imageRule) {
imageRule['exclude'] = /\.svg$/;
}

// Configure .svg files to be loaded with @svgr/webpack
config.module.rules.push({
Expand Down