Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codeowners: Fix codeowner docs glob #23610

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Codeowners: Fix codeowner docs glob #23610

merged 1 commit into from
Jul 26, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jul 26, 2023 •
edited
Loading

What I did

The current syntax matched all paths with docs in it.

image

How to test

Good question 🤔

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks ci:docs Run the CI jobs for documentation checks only. ci:normal and removed ci:docs Run the CI jobs for documentation checks only. labels Jul 26, 2023
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 26, 2023
@kasperpeulen kasperpeulen merged commit bf9b17f into next Jul 26, 2023
@kasperpeulen kasperpeulen deleted the kasper/codeowner-fix branch July 26, 2023 10:05
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
1621ca7 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
This was referenced Jul 26, 2023
Closed
Closed
Merged
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
934162b 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
1ed36fc 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
97dd756 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
bdf8c3b 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 26, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
60fe875 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
973eb2f 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
d8ae0b2 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 27, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
bf6e791 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
e94bcb7 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
87c3d93 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 28, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
1279006 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 31, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
c495646 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Jul 31, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
ff0dc65 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
@vanessayuenn vanessayuenn changed the title Maintainance: Fix codeowner docs glob Codeowners: Fix codeowner docs glob Aug 1, 2023
@vanessayuenn vanessayuenn added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Aug 1, 2023
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
e85e17b 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
5787b55 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
03797b9 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
595d7ee 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 1, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
f23d9be 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
6a8f003 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
15d1d87 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
b668926 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 2, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
458f547 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 3, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
f1c85b6 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Closed
32 tasks
storybook-bot pushed a commit that referenced this pull request Aug 4, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
8d06a4b 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
fc3cb36 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
cc6595a 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
6a9f71a 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
c899a1c 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 8, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
cc426ed 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
c9f862c 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
d065390 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
@kasperpeulen @storybook-bot
Merge pull request #23610 from storybookjs/kasper/codeowner-fix
4f23aa7 
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf yannbf approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kasperpeulen @yannbf @ndelangen @valentinpalkovic @vanessayuenn