Addon: Interactions - include the source of jest-mock #23593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Methuselah96 would you be willing to assist verifying if this PR resolves the issue your reported? I've triggered a canary release, it should appear soon allowing you to test this. |
|
@ndelangen Looks like you went with just downgrading |
|
Yes, though I'm not happy with that route. I'd love to know if this solution actually worked, so if you wouldn't mind testing it that would be 🙏 |
|
Makes sense. I tested this and it fixes the issue for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23570
What I did
I copied the source code of
jest-mockinto the source code of addon interactions.I did this because
jest-mockdepends onjest-util. Both these packages are compiled to CJS. That cannot be treeshaken, which causes the dependencies for (unused code-paths) injest-utilto be included in the browser bundle.How to test
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This pull request has been released as version
7.2.0-canary-23593-1690276507-975d4e05.0. Install it by pinning all your Storybook dependencies to that version.More information
7.2.0-canary-23593-1690276507-975d4e05.0norbert/jest-mock-included975d4e051690276507)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23593