Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add a ci:docs workflow #23575

Merged
merged 2 commits into from
Jul 25, 2023
Merged

CI: Add a ci:docs workflow #23575

merged 2 commits into from
Jul 25, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 24, 2023

@kylegach Here's what you suggested: a workflow for just docs.

What immediately is obvious is that we have configured a bunch of GitHub checks to be required, which do not run.
I don't really have a solution for this.

@ndelangen ndelangen added the ci:docs Run the CI jobs for documentation checks only. label Jul 24, 2023
@ndelangen ndelangen self-assigned this Jul 24, 2023
@ndelangen ndelangen added build Internal-facing build tooling & test updates patch:no labels Jul 24, 2023
@JReinhold
Copy link
Contributor

JReinhold commented Jul 24, 2023

What immediately is obvious is that we have configured a bunch of GitHub checks to be required, which do not run. I don't really have a solution for this.

They don't look required to me, they're just in an infinite pending state, which seems okay.

You're right. I also can't really think of a good solution here. @yannbf ?

@kylegach
Copy link
Contributor

@ndelangen — Thank you! ❤️

What immediately is obvious is that we have configured a bunch of GitHub checks to be required, which do not run.
I don't really have a solution for this.

Hmm... given that the other checks are not run, there's no harm to just always having to Merge without waiting for requirements to be met (bypass branch protections), is there? Both @jonniebigodes and I are admins, so that's workable for us, process-wise.

@JReinhold
Copy link
Contributor

there's no harm to just always having to Merge without waiting for requirements to be met (bypass branch protections), is there?

I'm okay with that @kylegach

@ndelangen ndelangen merged commit 6c5e599 into next Jul 25, 2023
13 checks passed
@ndelangen ndelangen deleted the norbert/ci-docs branch July 25, 2023 10:49
@vanessayuenn vanessayuenn mentioned this pull request Jul 26, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants